Add an index for user_id on all roles tables#4268
Merged
philippthun merged 1 commit intocloudfoundry:mainfrom Apr 8, 2025
Merged
Add an index for user_id on all roles tables#4268philippthun merged 1 commit intocloudfoundry:mainfrom
philippthun merged 1 commit intocloudfoundry:mainfrom
Conversation
Currently there is only a combined index (space/org_id + user_id) which cannot be used when accessing the table via user_id. Multiple role queries could benefit from a dedicated index on user_id. MySQL already has this index (for the foreign key constraint).
philippthun
force-pushed
the
user_id_index_for_roles
branch
from
96db071 to
90e6a0f
Compare
johha
approved these changes
Apr 1, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Apr 8, 2025
Changes in cloud_controller_ng:
- Add an index for user_id on all roles tables
PR: cloudfoundry/cloud_controller_ng#4268
Author: Philipp Thun <philipp.thun@sap.com>
- Skip migrations check for backwards compatibility tests
PR: cloudfoundry/cloud_controller_ng#4294
Author: Philipp Thun <philipp.thun@sap.com>
Dependency updates in cloud_controller_ng:
- build(deps-dev): bump byebug from 11.1.3 to 12.0.0
PR: cloudfoundry/cloud_controller_ng#4283
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is only a combined index (
space/org_id+user_id) which cannot be used when accessing the table viauser_id. Multiple role queries could benefit from a dedicated index onuser_id.MySQL already has this index (for the foreign key constraint).
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests